rdblue commented on code in PR #12512:
URL: https://github.com/apache/iceberg/pull/12512#discussion_r2006420320
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantReaders.java:
##########
@@ -1086,14 +1387,22 @@ private static GroupType field(String name, Type
shreddedType) {
.named(name);
}
+ private static GroupType list(Type shreddedType) {
+ return Types.optionalList()
Review Comment:
When the element type is passed in, I think it will be more straightforward
to construct this:
```java
Types.optionalList()
.element(elementType)
.named("typed_value");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
