rdblue commented on code in PR #12512:
URL: https://github.com/apache/iceberg/pull/12512#discussion_r2006284066
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantReaders.java:
##########
@@ -95,6 +96,19 @@ public static VariantValueReader objects(
fieldReaders);
}
+ public static VariantValueReader array(
+ int valueDefinitionLevel,
+ ParquetValueReader<?> valueReader,
+ int typedDefinitionLevel,
+ int repeatedDefinitionLevel,
+ int repeatedRepetitionLevel,
+ ParquetValueReader<?> elementReader) {
+ VariantValueReader typedReader =
+ new ListReader(
Review Comment:
The array reader looks good. I don't understand why this factory method is
creating two readers though. I think that this should create the array reader
and the caller should combine it with the other by calling `shredded`. That
way, there are fewer values passed in here and it is more straightforward. We
want to minimize passing DL, RL, or readers through the wrong args.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
