nastra commented on code in PR #12226:
URL: https://github.com/apache/iceberg/pull/12226#discussion_r2000690777
##########
core/src/main/java/org/apache/iceberg/PartitionStats.java:
##########
@@ -78,7 +78,16 @@ public int equalityDeleteFileCount() {
return equalityDeleteFileCount;
}
+ /**
+ * @deprecated since 1.9.0, will be removed in 1.10.0, use {@link
#totalRecordCountOptional()}
+ * instead.
+ */
+ @Deprecated
Review Comment:
do we really need to deprecate the existing method and introduce a new one
to handle this properly? I'm not a fan of having a method with `optional` in
the name. Also what if the field itself becomes a `Long` but the method's
return type stays the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
