nastra commented on code in PR #12226:
URL: https://github.com/apache/iceberg/pull/12226#discussion_r2001508692
##########
data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java:
##########
@@ -591,7 +591,7 @@ private static boolean isEqual(
&& stats1.positionDeleteFileCount() == stats2.positionDeleteFileCount()
&& stats1.equalityDeleteRecordCount() ==
stats2.equalityDeleteRecordCount()
&& stats1.equalityDeleteFileCount() == stats2.equalityDeleteFileCount()
- && stats1.totalRecordCount() == stats2.totalRecordCount()
+ && Objects.equals(stats1.totalRecords(), stats2.totalRecords())
Review Comment:
not directly related to this PR, but why can't we handle equals/hashcode in
`PartitionStats` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
