danielcweeks commented on code in PR #12496:
URL: https://github.com/apache/iceberg/pull/12496#discussion_r2007974525
##########
api/src/main/java/org/apache/iceberg/variants/VariantObject.java:
##########
@@ -57,4 +59,37 @@ static String asString(VariantObject object) {
return builder.toString();
}
+
+ static int hash(VariantObject self) {
+ int hash = 17;
+ for (String field : self.fieldNames()) {
Review Comment:
This has me a little concerned. It appears that we'll introduce a lot of
integer overflow since we're multiplying by the hash of the fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
