rdblue commented on code in PR #12496:
URL: https://github.com/apache/iceberg/pull/12496#discussion_r1988118292
##########
parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java:
##########
@@ -211,13 +211,13 @@ private static <T> List<T> visitFields(
}
private static <T> T visitVariant(
- Types.VariantType variant, GroupType group, TypeWithSchemaVisitor<T>
visitor) {
+ Types.VariantType variant, GroupType variantGroup,
TypeWithSchemaVisitor<T> visitor) {
Review Comment:
In order to call a visitor that has a different return type than the Parquet
schema visitor (in this case, `VariantMetrics` instead of `FieldMetrics`), the
Parquet type needs to be passed to the visit method. I think that not including
this originally was an accident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
