bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1993594031
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CommitterFactory.java:
##########
@@ -21,7 +21,7 @@
import org.apache.iceberg.connect.channel.CommitterImpl;
class CommitterFactory {
- static Committer createCommitter(IcebergSinkConfig config) {
+ static Committer createCommitter() {
Review Comment:
We should leave this as-is for now and address changes in the PR to support
different committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
