bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1985468217
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CommitterFactory.java:
##########
@@ -18,11 +18,13 @@
*/
package org.apache.iceberg.connect;
+import org.apache.iceberg.catalog.Catalog;
import org.apache.iceberg.connect.channel.CommitterImpl;
+import org.apache.kafka.connect.sink.SinkTaskContext;
class CommitterFactory {
- static Committer createCommitter(IcebergSinkConfig config) {
- return new CommitterImpl();
+ static Committer createCommitter(Catalog catalog, IcebergSinkConfig config,
SinkTaskContext context) {
Review Comment:
I feel we should revert this change, and initialize the members in the start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
