bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1993667055
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##########
@@ -43,6 +43,21 @@ public class CommitterImpl implements Committer {
private CoordinatorThread coordinatorThread;
private Worker worker;
+ private Catalog catalog;
+ private IcebergSinkConfig config;
+ private SinkTaskContext context;
+ private KafkaClientFactory clientFactory;
+ private Collection<MemberDescription> membersWhenWorkerIsCoordinator;
+ private final AtomicBoolean isCommitterInitialized = new
AtomicBoolean(false);
+
+ void initializeCommitter(Catalog catalog, IcebergSinkConfig config,
SinkTaskContext context) {
+ if (isCommitterInitialized.compareAndSet(false, true)) {
Review Comment:
I see, it might be a bit confusing calling committer `start` from the task
`open`. What do you think of naming the new committer methods `open` and
`close` instead, to align with the task API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
