zeroshade commented on code in PR #330:
URL: https://github.com/apache/iceberg-go/pull/330#discussion_r1991720680
##########
table/arrow_utils.go:
##########
@@ -1250,5 +1566,56 @@ func dataFileStatsFromParquetMetadata(pqmeta
*metadata.FileMetaData, statsCols m
nullValueCounts: nullValueCounts,
nanValueCounts: nanValueCounts,
splitOffsets: splitOffsets,
+ colAggs: colAggs,
+ }
+}
+
+func parquetFilesToDataFiles(fileIO iceio.IO, meta *MetadataBuilder, paths
iter.Seq[string]) iter.Seq2[iceberg.DataFile, error] {
Review Comment:
yup, name mapping is handled properly (as far as I can tell via testing)
though over the course of writing tests for the subsequent changes, I did find
a couple edge cases which I fixed in those commits. They'll be included in the
next PR after this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
