Fokko commented on code in PR #330: URL: https://github.com/apache/iceberg-go/pull/330#discussion_r1991154004
########## table/arrow_utils.go: ########## @@ -1250,5 +1566,56 @@ func dataFileStatsFromParquetMetadata(pqmeta *metadata.FileMetaData, statsCols m nullValueCounts: nullValueCounts, nanValueCounts: nanValueCounts, splitOffsets: splitOffsets, + colAggs: colAggs, + } +} + +func parquetFilesToDataFiles(fileIO iceio.IO, meta *MetadataBuilder, paths iter.Seq[string]) iter.Seq2[iceberg.DataFile, error] { Review Comment: I'm reluctant to add this with this PR. Do we handle the name-mapping properly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org