Re: [PR] feat(table): Basic Transaction and AddFiles [iceberg-go]

[via GitHub]

Fokko commented on code in PR #330:
URL: https://github.com/apache/iceberg-go/pull/330#discussion_r1990932226


##########
table/arrow_utils.go:
##########
@@ -908,6 +915,260 @@ func must[T any](v T, err error) T {
        return v
 }
 
+func primitiveToPhysicalType(typ iceberg.Type) string {
+       switch typ.(type) {
+       case iceberg.BooleanType:
+               return "BOOLEAN"
+       case iceberg.Int32Type:
+               return "INT32"
+       case iceberg.Int64Type:
+               return "INT64"
+       case iceberg.Float32Type:
+               return "FLOAT"
+       case iceberg.Float64Type:
+               return "DOUBLE"
+       case iceberg.DateType:
+               return "INT32"
+       case iceberg.TimeType:
+               return "INT64"
+       case iceberg.TimestampType:
+               return "INT64"
+       case iceberg.TimestampTzType:
+               return "INT64"
+       case iceberg.StringType:
+               return "BYTE_ARRAY"
+       case iceberg.UUIDType:
+               return "FIXED_LEN_BYTE_ARRAY"
+       case iceberg.FixedType:
+               return "FIXED_LEN_BYTE_ARRAY"
+       case iceberg.BinaryType:
+               return "BYTE_ARRAY"
+       case iceberg.DecimalType:
+               return "FIXED_LEN_BYTE_ARRAY"

Review Comment:
   For the decimal, it depends on the length
   
   
![image](https://github.com/user-attachments/assets/51c3a4b9-8966-4ad4-bef0-a63b6bb3f5e4)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org