wypoon commented on PR #12117: URL: https://github.com/apache/iceberg/pull/12117#issuecomment-2716148461
@RussellSpitzer thank you for reviewing the PR. I understand that you're not thrilled with the idea of two functions to do the same thing. However, this is already the case with the partition transforms (two forms supported to do the same thing). I feel that what should happen is to deprecate the plural forms for both the transforms and the system functions, and then remove them subsequently in favor of the singular forms. I just don't know what is the mechanism we use to do such a deprecation, since this is for the user-facing SQL (DDL and DML), and not Java API. @rdblue can you weigh in here? At the moment, I have kept the plural form of the system functions as the default. If we want to flush out the ramifications of replacing the plural with the singular form, I'd make the singular form the default, and I know that I'll need to modify more tests. I don't want to do that until we decide if we want to go ahead with this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
