RussellSpitzer commented on code in PR #12117:
URL: https://github.com/apache/iceberg/pull/12117#discussion_r1989631278
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/functions/DaysFunction.java:
##########
@@ -31,6 +31,8 @@
* A Spark function implementation for the Iceberg day transform.
*
* <p>Example usage: {@code SELECT system.days('source_col')}.
+ *
+ * <p>Alternate form: {@code SELECT system.day('source_col')}.
*/
public class DaysFunction extends UnaryUnboundFunction {
Review Comment:
I'm also not keen about having an arguement to this constructor. Why
Shouldn't I have DayFunction and DaysFunction. Where DayFunction just extends
DaysFunction but overrides the name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
