RussellSpitzer commented on PR #12117: URL: https://github.com/apache/iceberg/pull/12117#issuecomment-2714905429
I took a brief look through the whole PR. I really am a bit worried about the scope of code required to make this change and I'm not sure it matches the benefit of being able to say system.day instead of system.days. I feel like we are doing a lot of work and refactoring here and I'm not sure of all of the potential consequences. I need a better justification for why doing this will help folks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
