dramaticlly commented on code in PR #12228:
URL: https://github.com/apache/iceberg/pull/12228#discussion_r1990229315


##########
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##########
@@ -344,6 +344,24 @@ default void invalidateTable(TableIdentifier identifier) {}
    * @throws AlreadyExistsException if the table already exists in the catalog.
    */
   default Table registerTable(TableIdentifier identifier, String 
metadataFileLocation) {
+    return registerTable(
+        identifier, metadataFileLocation, false /* register only if it does 
not exist */);
+  }
+
+  /**
+   * Register a table with the catalog, optionally overwrite existing table 
metadata.
+   *
+   * <p><strong>Note:</strong> Overwriting an existing table may result in a 
new table UUID.

Review Comment:
   Actually, let me reword this. What I meant is that the existing table UUID 
might change after the register with overwrite (original UUID might change to 
UUID from the metadata.json if they are different)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to