zeroshade commented on code in PR #317:
URL: https://github.com/apache/iceberg-go/pull/317#discussion_r1985827437
##########
manifest.go:
##########
@@ -1519,7 +1492,13 @@ func (f *fallbackManifestEntryV1) toEntry()
*manifestEntryV1 {
return &f.manifestEntryV1
}
-func (m *manifestEntryV1) inheritSeqNum(manifest ManifestFile) {}
+func (m *manifestEntryV1) inherit(manifest ManifestFile) {
+ if m.Snapshot <= 0 {
+ m.Snapshot = manifest.SnapshotID()
+ }
Review Comment:
I've spun this idea out into a separate change at
https://github.com/apache/iceberg-go/pull/327 as the refactoring is kinda large
and I didn't want to increase the size of this change too much.
Does that work for you @Fokko ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
