Fokko commented on code in PR #317:
URL: https://github.com/apache/iceberg-go/pull/317#discussion_r1984823063
##########
manifest.go:
##########
@@ -1519,7 +1492,13 @@ func (f *fallbackManifestEntryV1) toEntry()
*manifestEntryV1 {
return &f.manifestEntryV1
}
-func (m *manifestEntryV1) inheritSeqNum(manifest ManifestFile) {}
+func (m *manifestEntryV1) inherit(manifest ManifestFile) {
+ if m.Snapshot <= 0 {
+ m.Snapshot = manifest.SnapshotID()
+ }
Review Comment:
Wouldn't it be better to generalize this for V1/V2? And inherit both the
snapshot and sequence numbers. That's what we do for PyIceberg anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
