kumarpritam863 commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1985439435
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CommitterFactory.java:
##########
@@ -18,11 +18,13 @@
*/
package org.apache.iceberg.connect;
+import org.apache.iceberg.catalog.Catalog;
import org.apache.iceberg.connect.channel.CommitterImpl;
+import org.apache.kafka.connect.sink.SinkTaskContext;
class CommitterFactory {
- static Committer createCommitter(IcebergSinkConfig config) {
- return new CommitterImpl();
+ static Committer createCommitter(Catalog catalog, IcebergSinkConfig config,
SinkTaskContext context) {
Review Comment:
Here I am passing this as I want the committer to be created at the global
level as committer is a global resource and its creation is not dependent on
partition added and removed.
Why I have not removed it from the start as we wanted to keep the structure
of the start same for backward compatibility. Ideally the start should be
similar to stop with only one argument Collection<TopicPartitions>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
