bryanck commented on code in PR #12372: URL: https://github.com/apache/iceberg/pull/12372#discussion_r1985402337
########## kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/Committer.java: ########## @@ -20,13 +20,70 @@ import java.util.Collection; import org.apache.iceberg.catalog.Catalog; +import org.apache.kafka.common.TopicPartition; import org.apache.kafka.connect.sink.SinkRecord; import org.apache.kafka.connect.sink.SinkTaskContext; +/** + * The Committer interface defines methods for handling the commit process + * in the Iceberg Sink Connector. It provides operations for starting, stopping, Review Comment: The comments are too verbose and have redundant information. Can you either make the text more concise or remove the comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
