bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1967888780
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/Committer.java:
##########
@@ -19,14 +19,21 @@
package org.apache.iceberg.connect;
import java.util.Collection;
-import org.apache.iceberg.catalog.Catalog;
import org.apache.kafka.connect.sink.SinkRecord;
-import org.apache.kafka.connect.sink.SinkTaskContext;
+import org.apache.kafka.common.TopicPartition;
public interface Committer {
- void start(Catalog catalog, IcebergSinkConfig config, SinkTaskContext
context);
+ void startCoordinator();
Review Comment:
Something I should have brought up sooner, the `Committer` interface is
meant to be generic, i.e. you could plug in a committer that uses server-side
coordination, and in that case these new methods aren't relevant. Also, this is
modifying a public interface, and that could be a breaking change for some.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
