mxm commented on code in PR #12424: URL: https://github.com/apache/iceberg/pull/12424#discussion_r1979405428
########## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/PartitionSpecAdjustment.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.sink.dynamic; + +import org.apache.iceberg.PartitionField; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.Schema; +import org.apache.iceberg.UnboundPartitionSpec; + +public class PartitionSpecAdjustment { + + private PartitionSpecAdjustment() {} + + public static PartitionSpec adjustPartitionSpecToTableSchema( + Schema tableSchema, PartitionSpec userSpec) { + if (userSpec.isUnpartitioned()) { + return userSpec; + } + UnboundPartitionSpec.Builder builder = Review Comment: A little bit of background: The Dynamic Sink matches field names based on their names, not their ids. The reason for this is that (a) the Iceberg Java API solely works based on names (b) we found that it's difficult for users to use the correct ids based on the current table schema / spec. The ids are usually dictated by the input schema, e.g. Avro which might use different ids, e.g. starting from 0 instead of 1. The adjustment here ensures that the user-provided spec alongside with its schema can be mapped to one of the existing schema / spec. This is to avoid creating unnecessary table schema / spec when the schema / spec is otherwise identical. For example: - Input schema {"id", 0, int} Input spec: {bucket[0][10]} - Table schema: {"id, 1, int} Table spec: {bucket[1][10]} The logic would rewrite the input spec to match the table spec, because field id 0 ("id") in the input schema matches field id 1 ("id") in the table schema. This is then later used to resolved the table spec from the cache. The rewrite isn't strictly necessary though, we can achieve the same by simply comparing. I've revised the logic in the latest commit. It's now integrated directly with cache lookup / update logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
