stevenzwu commented on code in PR #12424: URL: https://github.com/apache/iceberg/pull/12424#discussion_r1980330718
########## flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/PartitionSpecAdjustment.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.sink.dynamic; + +import org.apache.iceberg.PartitionField; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.Schema; +import org.apache.iceberg.UnboundPartitionSpec; + +public class PartitionSpecAdjustment { + + private PartitionSpecAdjustment() {} + + public static PartitionSpec adjustPartitionSpecToTableSchema( + Schema tableSchema, PartitionSpec userSpec) { + if (userSpec.isUnpartitioned()) { + return userSpec; + } + UnboundPartitionSpec.Builder builder = Review Comment: > For example: > Input schema {"id", 0, int} Input spec: {bucket[0][10]} > Table schema: {"id, 1, int} Table spec: {bucket[1][10]} I don't fully get the example. In `PartitionSpecEvolution`, src/input spec is Iceberg's `PartitionSpec`. why would the input spec different with the table spec in terms of field ids? how is the input spec constructed (especially regarding source field name and id)? if you have a unit test to demonstrate the scenario, please point it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
