Fokko commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r1977678422
########## pyiceberg/types.py: ########## @@ -175,6 +179,10 @@ def is_primitive(self) -> bool: def is_struct(self) -> bool: return isinstance(self, StructType) + def minimum_format_version(self) -> int: Review Comment: Let's throw in a nice alias: ```suggestion def minimum_format_version(self) -> TableVersion: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org