sungwy commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r1977676297
########## pyiceberg/transforms.py: ########## @@ -323,6 +327,16 @@ def hash_func(v: Any) -> int: return mmh3.hash(struct.pack("<q", v)) + elif isinstance(source, (TimestampNanoType, TimestamptzNanoType)): + + def hash_func(v: Any) -> int: + if isinstance(v, py_datetime.datetime): + v = datetime.datetime_to_micros(v) Review Comment: Haha - I meant to leave a comment here. Will do so we aren't confused reading this in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org