munendrasn commented on code in PR #11979:
URL: https://github.com/apache/iceberg/pull/11979#discussion_r1973048206
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -480,6 +486,13 @@ public Builder withObjectMapper(ObjectMapper objectMapper)
{
return this;
}
+ public Builder withTlsSocketStrategy(TlsSocketStrategy socketStrategy) {
+ Preconditions.checkNotNull(
+ socketStrategy, "Invalid tls socket strategy for http client proxy:
null");
Review Comment:
As `tlsSocketStrategy` can be null when not explicitly set, validation can't
be added to `build`. Hence, ensuring that if socketStrategy is explicitly set,
it should be non-null
This similar to handling other configuration on the builder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
