nastra commented on code in PR #11979:
URL: https://github.com/apache/iceberg/pull/11979#discussion_r1958434510
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -374,13 +375,17 @@ static HttpRequestInterceptor loadInterceptorDynamically(
return instance;
}
- static HttpClientConnectionManager configureConnectionManager(Map<String,
String> properties) {
+ static HttpClientConnectionManager configureConnectionManager(
+ Map<String, String> properties, TlsSocketStrategy tlsSocketStrategy) {
PoolingHttpClientConnectionManagerBuilder connectionManagerBuilder =
PoolingHttpClientConnectionManagerBuilder.create();
ConnectionConfig connectionConfig = configureConnectionConfig(properties);
if (connectionConfig != null) {
connectionManagerBuilder.setDefaultConnectionConfig(connectionConfig);
}
+ if (tlsSocketStrategy != null) {
+ connectionManagerBuilder.setTlsSocketStrategy(tlsSocketStrategy);
Review Comment:
ok this is probably fine to just be configured through the builder. I'm ok
with this change but let's see what other reviewers think of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
