nastra commented on code in PR #11979:
URL: https://github.com/apache/iceberg/pull/11979#discussion_r1958432024
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -480,6 +486,11 @@ public Builder withObjectMapper(ObjectMapper objectMapper)
{
return this;
}
+ public Builder withTlsSocketStrategy(TlsSocketStrategy socketStrategy) {
+ this.tlsSocketStrategy = socketStrategy;
Review Comment:
we should make sure in the build method that this isn't null. Also we should
have some tests when this is null or configured to a real value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
