rdblue commented on PR #12238: URL: https://github.com/apache/iceberg/pull/12238#issuecomment-2680076226
This is close. There are just two blockers for me: 1. This should not expose unnecessary constants in `Variant`. Cross-project constant use is unnecessary API surface and can cause issues because it entails unnecessary classloading. 2. The custom order schema visitor should also pass metadata and value result futures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
