rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1968634436
##########
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##########
@@ -22,6 +22,10 @@
/** A variant metadata and value pair. */
public interface Variant {
+ String METADATA = "metadata";
+ String VALUE = "value";
+ String TYPED_VALUE = "typed_value";
Review Comment:
I don't think we should expose constants here. Can you remove them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
