rdblue commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1968636242
##########
core/src/main/java/org/apache/iceberg/avro/AvroCustomOrderSchemaVisitor.java:
##########
@@ -47,7 +47,13 @@ public static <T, F> T visit(Schema schema,
AvroCustomOrderSchemaVisitor<T, F> v
visitor.recordLevels.pop();
- return visitor.record(schema, names, Iterables.transform(results,
Supplier::get));
+ if (schema.getLogicalType() instanceof VariantLogicalType) {
+ Preconditions.checkArgument(
+ AvroSchemaUtil.isVariantSchema(schema), "Invalid variant record:
%s", schema);
+ return visitor.variant(schema);
Review Comment:
This should pass the futures for the metadata and value fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
