RussellSpitzer commented on code in PR #12327:
URL: https://github.com/apache/iceberg/pull/12327#discussion_r1968558602
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java:
##########
@@ -265,55 +271,16 @@ public String description() {
return "AddFiles";
}
- private void validatePartitionSpec(Table table, Map<String, String>
partitionFilter) {
- List<PartitionField> partitionFields = table.spec().fields();
- Set<String> partitionNames =
-
table.spec().fields().stream().map(PartitionField::name).collect(Collectors.toSet());
-
- boolean tablePartitioned = !partitionFields.isEmpty();
- boolean partitionSpecPassed = !partitionFilter.isEmpty();
-
+ private void nonIdentityPartitionCheck(Table table) {
// Check for any non-identity partition columns
List<PartitionField> nonIdentityFields =
- partitionFields.stream()
+ table.spec().fields().stream()
Review Comment:
This would be wrong then, because we are adding files with a different spec
id. It's ok to have a current spec with a different partitioning with
nonIdentityFields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
