RussellSpitzer commented on code in PR #12327:
URL: https://github.com/apache/iceberg/pull/12327#discussion_r1968555311
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java:
##########
@@ -265,55 +271,16 @@ public String description() {
return "AddFiles";
}
- private void validatePartitionSpec(Table table, Map<String, String>
partitionFilter) {
- List<PartitionField> partitionFields = table.spec().fields();
- Set<String> partitionNames =
-
table.spec().fields().stream().map(PartitionField::name).collect(Collectors.toSet());
-
- boolean tablePartitioned = !partitionFields.isEmpty();
- boolean partitionSpecPassed = !partitionFilter.isEmpty();
-
+ private void nonIdentityPartitionCheck(Table table) {
Review Comment:
This is impossible now right? We've removed the ability to even locate a
spec that isn't all identity columns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
