RussellSpitzer commented on code in PR #12327:
URL: https://github.com/apache/iceberg/pull/12327#discussion_r1968550486
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -1091,21 +1094,9 @@ private ExecutorService getService() {
/**
* Returns the first partition spec in an IcebergTable that shares the same
names and ordering as
- * the partition columns in a given Spark Table. Throws an error if not found
+ * the partition columns provided. Throws an error if not found
*/
- private static PartitionSpec findCompatibleSpec(
- Table icebergTable, SparkSession spark, String sparkTable) throws
AnalysisException {
- List<String> parts =
Lists.newArrayList(Splitter.on('.').limit(2).split(sparkTable));
- String db = parts.size() == 1 ? "default" : parts.get(0);
- String table = parts.get(parts.size() == 1 ? 0 : 1);
-
- List<String> sparkPartNames =
- spark.catalog().listColumns(db, table).collectAsList().stream()
- .filter(org.apache.spark.sql.catalog.Column::isPartition)
- .map(org.apache.spark.sql.catalog.Column::name)
- .map(name -> name.toLowerCase(Locale.ROOT))
- .collect(Collectors.toList());
-
+ public static PartitionSpec findCompatibleSpec(List<String> partitionNames,
Table icebergTable) {
Review Comment:
Could we keep this package private? Just to avoid exposing another api to
the general public unless we have a need to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
