bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1967893979
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/Committer.java:
##########
@@ -19,14 +19,21 @@
package org.apache.iceberg.connect;
import java.util.Collection;
-import org.apache.iceberg.catalog.Catalog;
import org.apache.kafka.connect.sink.SinkRecord;
-import org.apache.kafka.connect.sink.SinkTaskContext;
+import org.apache.kafka.common.TopicPartition;
public interface Committer {
- void start(Catalog catalog, IcebergSinkConfig config, SinkTaskContext
context);
+ void startCoordinator();
- void stop();
+ void startWorker();
+
+ void stopCoordinator();
+
+ void stopWorker();
void save(Collection<SinkRecord> sinkRecords);
+
+ boolean isCoordinator(Collection<TopicPartition> currentAssignedPartitions);
Review Comment:
I don't think the naming here is accurate either, i.e. this could return
false even for a task that is the coordinator node. Also, this isn't relevant
to other types of committers that aren't using a coordinator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
