pvary commented on code in PR #12199:
URL: https://github.com/apache/iceberg/pull/12199#discussion_r1963147416
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java:
##########
@@ -151,22 +126,28 @@ private static TableLoader createTableLoader(
String databaseName,
String tableName) {
Configuration flinkConf = new Configuration();
- tableProps.forEach(flinkConf::setString);
- String catalogName = flinkConf.getString(CATALOG_NAME);
+ Map<String, String> mergedProps = mergeSrcCatalogProps(tableProps);
Review Comment:
Either here, or in the javadoc for the `mergeSrcCatalogProps` please
describe what we are doing, and why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
