pvary commented on code in PR #12199:
URL: https://github.com/apache/iceberg/pull/12199#discussion_r1963138956
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -332,7 +335,17 @@ public List<String> listTables(String databaseName)
public CatalogTable getTable(ObjectPath tablePath)
throws TableNotExistException, CatalogException {
Table table = loadIcebergTable(tablePath);
- return toCatalogTable(table);
+
+ String srcCatalogProps =
+ FlinkCreateTableOptions.toJson(
+ getName(), tablePath.getDatabaseName(), tablePath.getObjectName(),
catalogProps);
+
+ ImmutableMap.Builder<String, String> mergedProps = ImmutableMap.builder();
+ mergedProps.put("connector", FlinkDynamicTableFactory.FACTORY_IDENTIFIER);
+ mergedProps.put(FlinkCreateTableOptions.SRC_CATALOG_PROPS_KEY,
srcCatalogProps);
+ mergedProps.putAll(table.properties());
Review Comment:
Could we please add a comment here, that we store the catalog properties in
the merged property list to work around the Flink API limitations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
