pvary commented on code in PR #12199:
URL: https://github.com/apache/iceberg/pull/12199#discussion_r1961351879
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -406,7 +422,8 @@ void createIcebergTable(ObjectPath tablePath,
ResolvedCatalogTable table, boolea
for (Map.Entry<String, String> entry : table.getOptions().entrySet()) {
if ("location".equalsIgnoreCase(entry.getKey())) {
location = entry.getValue();
- } else {
+ } else if (!("connector".equalsIgnoreCase(entry.getKey())
+ ||
FlinkCreateTableOptions.SRC_CATALOG_PROPS_KEY.equalsIgnoreCase(entry.getKey())))
{
Review Comment:
It took me some time to decipher this 😄
Could we please break up the negation so it doesn't span multiple lines?
Maybe:
```
} else if (!"connector".equalsIgnoreCase(entry.getKey())
&&
!FlinkCreateTableOptions.SRC_CATALOG_PROPS_KEY.equalsIgnoreCase(entry.getKey()))
{
```
Or it is just me?
Also maybe a comment should be nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
