Fokko commented on code in PR #960:
URL: https://github.com/apache/iceberg-rust/pull/960#discussion_r1954451652
##########
crates/iceberg/src/transaction.rs:
##########
@@ -169,6 +175,172 @@ impl<'a> Transaction<'a> {
catalog.update_table(table_commit).await
}
+
+ /// Adds existing parquet files
+ pub async fn add_parquet_files(
+ self,
+ file_paths: Vec<String>,
+ check_duplicate_files: bool,
+ ) -> Result<Transaction<'a>> {
+ if check_duplicate_files {
Review Comment:
This is different than in PyIceberg where we check if the file is already
part of the table. Here we just check if duplicate entries are in the
`file_paths` vector, which I don't think is very valuable.
If you add a file to a table, it is not easy to drop it without going into
the actual metadata, therefore this check has been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
