liurenjie1024 commented on code in PR #960:
URL: https://github.com/apache/iceberg-rust/pull/960#discussion_r1968794863
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -391,6 +404,79 @@ impl ParquetWriter {
);
Ok(builder)
}
+
+ /// `ParquetMetadata` to data file builder
+ pub fn parquet_to_data_file_builder(
+ schema: SchemaRef,
+ metadata: Arc<ParquetMetaData>,
Review Comment:
You are right, currently used
[`FileMetadata`](https://docs.rs/parquet/latest/parquet/format/struct.FileMetaData.html)
is the auto generated data structure from thrift definition, while the
[`FileMetadata`](https://docs.rs/parquet/latest/parquet/file/metadata/struct.FileMetaData.html)
I'm suggesting is an in memory representation of it. I think we should use the
in memory representation in the original one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
