mattmartin14 commented on PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#issuecomment-2651601160
@Fokko @kevinjqliu - i was able to run the "make lint" command and I've resolved i think 99% of it; the only thing that make lint is flagging is: ```bash pyiceberg/table/upsert_util.py:65: error: Statement is unreachable [unreachable] pyiceberg/table/upsert_util.py:81: error: Statement is unreachable [unreachable] tests/table/test_upsert.py:18: error: Cannot find implementation or library stub for module named "datafusion" [import-not-found] ``` On datafusion, that's odd because i know the package is installed, its in the poetry pyproject.toml file as well as the lock file and my test cases run just fine. The only thing i'm not sure i am able to resolve is those unreacable error flags; is that a deal breaker? is that something you can help show me an example on resolving? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
