mattmartin14 commented on PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#issuecomment-2649303687
> Looks like CI failed due to the linter, can you run `make lint` locally? > > > i updated my original description to have a link to PR 402; > > It would be great to rewrite the description so that it captures the changes in this PR. The description will be where folks will read about this change in the future and it'll be part of the commit message when merged. A good description would be to include the context for the change, the changes that were made, and anything worth calling out. > > For example, in this PR we added a top-level API, `upsert`, to the `Table` class > > > Is there something else I need to do @kevinjqliu on the poetry project file to enable this? > > let me pull this locally and try it out it looks like my firewall is blocking me from running "make lint"; sorry, i can keep digging on this, but it might take me a couple days to resolve an internal firewall issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
