mattmartin14 commented on PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#issuecomment-2650818707
> @mattmartin14 i tried to fix as many linter issue as possible, the changes are in https://github.com/apache/iceberg-python/compare/main...kevinjqliu:iceberg-python:kevinjqliu/1534-upsert?expand=1 > > Feel free to cherry-pick the commits. > > There are still a few linter issue left, some of which i didn't get time to dig into > > ``` > mypy.....................................................................Failed > - hook id: mypy > - exit code: 1 > > pyiceberg/table/upsert_util.py:59: error: Statement is unreachable [unreachable] > pyiceberg/table/upsert_util.py:75: error: Statement is unreachable [unreachable] > pyiceberg/table/upsert_util.py:104: error: Missing type parameters for generic type "list" [type-arg] > pyiceberg/table/upsert_util.py:114: error: Statement is unreachable [unreachable] > pyiceberg/table/upsert_util.py:116: error: Unsupported operand type for ~ ("Any | None") [operator] > Found 5 errors in 1 file (checked 145 source files) > ``` > > > i was able to run: ruff check --fix > > we dont use ruff directly, there are some rules that are applied. does `make lint` work for you? @kevinjqliu - i tried to cherry pick some of your stuff and git is saying those hashes arent' available; almost like they are in some repo outside of pyiceberg. If you put them in your own personal repo/branch, can you instead add these cherry picks in the pyiceberg repo? - otherwise, given my company's firewall rules, i won't ever be able to reach them. I appreciate all teh help here! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
