rdblue commented on code in PR #10981:
URL: https://github.com/apache/iceberg/pull/10981#discussion_r1941752039


##########
format/spec.md:
##########
@@ -1480,6 +1497,9 @@ This serialization scheme is for storing single values as 
individual binary valu
 | **`struct`**                 | Not supported                                 
                                                               |
 | **`list`**                   | Not supported                                 
                                                               |
 | **`map`**                    | Not supported                                 
                                                               |
+| **`geometry`**               | A single point, encoded as a {x, y, optional 
z, optional m} concatenation of its 8-byte little-endian IEEE 754 coordinate 
values, with the optional coordinates encoded as NaN if unset. |
+| **`geography`**              | A single point, encoded as a {x, y, optional 
z, optional m} concatenation of its 8-byte little-endian IEEE 754 coordinate 
values, with the optional coordinates encoded as NaN if unset. |

Review Comment:
   Sorry, I should have taken a bit more time to reply. I think we can use the 
rules I suggested above and just say that if the Z dimension isn't present, 
then it should be set to NaN. That way the most common cases (X,Y and X,Y,Z) 
are compact.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to