gruuya commented on PR #924: URL: https://github.com/apache/iceberg-rust/pull/924#issuecomment-2629270601
> * Before this PR, tests are compiled into separated binaries. In theory they can run concurrently (e.g., if use `cargo nextest`), but just `cargo test` will run them in serial. Correct; at present the tests can't be run concurrently because they depend on separate docker container sets. (Also even if they didn't, `cargo nextest` would compile each top-level test file separately.) > * In this PR, we put them into 1 binary. And then they are run concurrently by `#[tokio::tests]`. > > * We use "shared container" to also save the time of spinning up and down containers. But need to take care of potential conflicts. Yep, that's it in a nutshell. Using the shared container set is the biggest time-saver (eliminating the docker build-start-stop overhead for each test). Having made them use shared containers, the next simple improvement is to make them all compile to one test binary (thus eliminating multiple compilations), as is done through having a single top-level `shared.rs` file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
