gruuya commented on PR #924: URL: https://github.com/apache/iceberg-rust/pull/924#issuecomment-2624970251
> generally lgtm. Since we're using a shared catalog, are there any concerns with side effects? In pyiceberg we use a [table identifier fixture](https://github.com/apache/iceberg-python/blob/361a407028272f90b092a79dafef96aeb19d52a5/tests/catalog/test_sql.py#L72-L75) to generate table names so they dont conflict Good point, I could also extract the namespace as a shared fixture among the tests (in the PR i just ignore the result of `create_namespace` assuming it was already created if it was an error). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
