gruuya commented on code in PR #924:
URL: https://github.com/apache/iceberg-rust/pull/924#discussion_r1935593788
##########
crates/integration_tests/src/lib.rs:
##########
@@ -18,31 +18,32 @@
use std::collections::HashMap;
use iceberg::io::{S3_ACCESS_KEY_ID, S3_ENDPOINT, S3_REGION,
S3_SECRET_ACCESS_KEY};
-use iceberg_catalog_rest::{RestCatalog, RestCatalogConfig};
+use iceberg_catalog_rest::RestCatalogConfig;
use iceberg_test_utils::docker::DockerCompose;
use iceberg_test_utils::{normalize_test_name, set_up};
const REST_CATALOG_PORT: u16 = 8181;
pub struct TestFixture {
pub _docker_compose: DockerCompose,
- pub rest_catalog: RestCatalog,
+ pub catalog_config: RestCatalogConfig,
Review Comment:
Since the tests now share this fixture but they're all executed in different
runtimes, they can't share the same client, as those can get [dropped
prematurely](https://github.com/seanmonstar/reqwest/issues/1148) when a test
ends, resulting in `dispatch task is gone: runtime dropped the dispatch task`
##########
crates/integration_tests/tests/shared/append_partition_data_file_test.rs:
##########
@@ -77,13 +78,12 @@ async fn test_append_partition_data_file() {
.expect("could not bind to schema");
let table_creation = TableCreation::builder()
- .name("t1".to_string())
+ .name("t2".to_string())
Review Comment:
Making the write tests use different tables each allows for them to also use
the shared docker stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
