RussellSpitzer commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1938246839
########## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ########## @@ -312,6 +341,8 @@ public void testBackwardCompat() throws Exception { .isEqualTo(previousSnapshot.allManifests(ops.io())); assertThat(metadata.previousFiles()).isEqualTo(expected.previousFiles()); assertThat(metadata.snapshot(previousSnapshotId).schemaId()).isNull(); + assertThat(metadata.rowLineageEnabled()).isEqualTo(expected.rowLineageEnabled()); + assertThat(metadata.nextRowId()).isEqualTo(expected.nextRowId()); Review Comment: I can a make a separate test for just this but it looked like our previous behavior was to just keep fattening up the JsonConversion test with new fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org