nastra commented on code in PR #11948: URL: https://github.com/apache/iceberg/pull/11948#discussion_r1935896138
########## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ########## @@ -312,6 +341,8 @@ public void testBackwardCompat() throws Exception { .isEqualTo(previousSnapshot.allManifests(ops.io())); assertThat(metadata.previousFiles()).isEqualTo(expected.previousFiles()); assertThat(metadata.snapshot(previousSnapshotId).schemaId()).isNull(); + assertThat(metadata.rowLineageEnabled()).isEqualTo(expected.rowLineageEnabled()); + assertThat(metadata.nextRowId()).isEqualTo(expected.nextRowId()); Review Comment: `testJsonConversionWithRowLineage ` checks this at the snapshot level but here we're at table metadata level, so I think it would be good to have a small test case here too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org