RussellSpitzer commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1928910159
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -282,6 +283,13 @@ public Snapshot apply() {
throw new RuntimeIOException(e, "Failed to write manifest list file");
}
+ Long addedRows = null;
+ Long lastRowId = null;
+ if (base.rowLineageEnabled()) {
+ addedRows = calculateAddedRows(manifests);
Review Comment:
It's worth thinking about, but here I'm not sure it's that much of an
optimization. The amount of new manifests should be pretty small, even if it
was thousands of manifests the overhead should be very low imho and we already
have them in memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
